[
https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424341#comment-16424341
]
Roger Whitcomb commented on PIVOT-1032:
---------------------------------------
Current state of the onion:
{quote}{{[LocalFinalVariableName] 1}}
{{[MethodName] 1}}
{{[ParameterName] 1}}
{{[RegexpSingleline] 1}}
{{[TypeName] 1}}
{{[LocalVariableName] 2}}
{{[NoWhitespaceBefore] 2}}
{{[EmptyStatement] 3}}
{{[FileLength] 3}}
{{[MemberName] 3}}
{{[UpperEll] 3}}
{{[NewlineAtEndOfFile] 6}}
{{[ArrayTypeStyle] 7}}
{{[EmptyBlock] 7}}
{{[FinalClass] 7}}
{{[NeedBraces] 8}}
{{[RedundantImport] 8}}
{{[AvoidStarImport] 9}}
{{[StaticVariableName] 12}}
{{[ParameterNumber] 13}}
{{[RightCurly] 13}}
{{[LeftCurly] 15}}
{{[ConstantName] 16}}
{{[HideUtilityClassConstructor] 19}}
{{[MissingSwitchDefault] 19}}
{{[SimplifyBooleanExpression] 28}}
{{[WhitespaceAround] 28}}
{{[MethodLength] 32}}
{{[JavadocStyle] 38}}
{{[InnerAssignment] 40}}
{{[ParenPad] 43}}
{{[NoWhitespaceAfter] 60}}
{{[TodoComment] 63}}
{{[OperatorWrap] 72}}
{{[JavadocPackage] 100}}
{{[MethodParamPad] 156}}
{{[UnusedImports] 166}}
{{[WhitespaceAfter] 233}}
{{[VisibilityModifier] 263}}
{{[LineLength] 378}}
{{[AvoidNestedBlocks] 400}}
{{[JavadocType] 504}}
{{[AvoidInlineConditionals] 514}}
{{[ModifierOrder] 525}}
{{[RedundantModifier] 1210}}
{{[MagicNumber] 1582}}
{{[HiddenField] 2157}}
{{[JavadocVariable] 3972}}
{{[JavadocMethod] 4268}}
{{[DesignForExtension] 4842}}
{{[FinalParameters] 12263}}
{{Grand Total 34117}}{quote}
> Implement "checkstyle" for builds and make changes to bring code into better
> compliance
> ---------------------------------------------------------------------------------------
>
> Key: PIVOT-1032
> URL: https://issues.apache.org/jira/browse/PIVOT-1032
> Project: Pivot
> Issue Type: Improvement
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Attachments: 1032.diffs.txt
>
>
> I thought it would be interesting, in addition to the "trim-whitespace" task
> already implemented, to do some sort of "checkstyle" processing to evaluate
> all the code to see where there might be changes to make the code more robust
> and a better example of "canonical" Java style.
> I hesitate to expect that we could address everything (or indeed whether we
> *should*), but there might be things that would make the code better and
> easier to read and maintain, and wouldn't take much effort.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
