[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425835#comment-16425835 ]
Roger Whitcomb commented on PIVOT-1032: --------------------------------------- Fix the cases of [WhitespaceAround]: Sending core\src\org\apache\pivot\beans\BXMLSerializer.java Sending core\src\org\apache\pivot\collections\ArrayStack.java Sending core\src\org\apache\pivot\collections\LinkedStack.java Sending core\src\org\apache\pivot\util\Utils.java Sending core\test\org\apache\pivot\functional\monad\test\OptionTest.java Sending tests\src\org\apache\pivot\tests\issues\pivot964\Pivot964Swing.java Sending wtk\src\org\apache\pivot\wtk\ScrollBar.java Sending wtk\src\org\apache\pivot\wtk\TextPane.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraAlertSkin.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraFileBrowserSkin.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraVFSBrowserSkin.java Transmitting file data ...........done Committing transaction... Committed revision 1828362. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --------------------------------------------------------------------------------------- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement > Reporter: Roger Whitcomb > Assignee: Roger Whitcomb > Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)