[
https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425956#comment-16425956
]
Roger Whitcomb commented on PIVOT-1032:
---------------------------------------
Fix a number of "easy" things:
Sending core/src/org/apache/pivot/collections/Dictionary.java
Sending core/src/org/apache/pivot/functional/functions/FunctionN.java
Sending core/src/org/apache/pivot/functional/functions/ProcedureN.java
Sending core/src/org/apache/pivot/serialization/MacroReader.java
Sending core/src/org/apache/pivot/text/CompositeIterator.java
Sending core/src/org/apache/pivot/text/FileSizeFormat.java
Sending core/src/org/apache/pivot/util/CalendarDate.java
Sending core/src/org/apache/pivot/util/Console.java
Sending core/src/org/apache/pivot/util/Time.java
Sending core/src/org/apache/pivot/xml/Element.java
Sending core/test/org/apache/pivot/beans/test/BeanAdapterTest.java
Sending
core/test/org/apache/pivot/serialization/test/StringSerializerTest.java
Sending demos/src/org/apache/pivot/demos/swing/SwingDemo.java
Sending
examples/src/org/apache/pivot/examples/sheets/SheetSlideDirectionWindow.java
Sending tests/src/org/apache/pivot/tests/IterationTest.java
Sending tests/src/org/apache/pivot/tests/TableViewCellRendererCustom.java
Sending
tests/src/org/apache/pivot/tests/issues/pivot964/Pivot964Swing.java
Sending
tutorials/src/org/apache/pivot/tutorials/bxmlexplorer/FakeWindow.java
Sending wtk/src/org/apache/pivot/wtk/ApplicationContext.java
Sending wtk/src/org/apache/pivot/wtk/Checkbox.java
Sending wtk/src/org/apache/pivot/wtk/Container.java
Sending wtk/src/org/apache/pivot/wtk/MenuButton.java
Sending wtk/src/org/apache/pivot/wtk/RadioButton.java
Sending wtk/src/org/apache/pivot/wtk/Ruler.java
Sending wtk/src/org/apache/pivot/wtk/TextPane.java
Sending wtk/src/org/apache/pivot/wtk/content/CalendarDateSpinnerData.java
Sending
wtk/src/org/apache/pivot/wtk/skin/TextPaneSkinComponentNodeView.java
Sending wtk/src/org/apache/pivot/wtk/skin/TextPaneSkinDocumentView.java
Sending wtk/src/org/apache/pivot/wtk/skin/TextPaneSkinImageNodeView.java
Sending wtk/src/org/apache/pivot/wtk/skin/TextPaneSkinListItemView.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTabPaneSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraVFSBrowserSkin.java
Transmitting file data ................................done
Committing transaction...
Committed revision 1828370.
> Implement "checkstyle" for builds and make changes to bring code into better
> compliance
> ---------------------------------------------------------------------------------------
>
> Key: PIVOT-1032
> URL: https://issues.apache.org/jira/browse/PIVOT-1032
> Project: Pivot
> Issue Type: Improvement
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Attachments: 1032.diffs.txt
>
>
> I thought it would be interesting, in addition to the "trim-whitespace" task
> already implemented, to do some sort of "checkstyle" processing to evaluate
> all the code to see where there might be changes to make the code more robust
> and a better example of "canonical" Java style.
> I hesitate to expect that we could address everything (or indeed whether we
> *should*), but there might be things that would make the code better and
> easier to read and maintain, and wouldn't take much effort.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
