[
https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453048#comment-16453048
]
Roger Whitcomb commented on PIVOT-1032:
---------------------------------------
The UnusedImports fixed in the "wtk-terra" files:
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraAccordionSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraActivityIndicatorSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraCalendarButtonSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraCalendarSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraCheckboxSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraColorChooserButtonSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraDialogSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraExpanderSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraFileBrowserSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraFormSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraFrameSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraGaugeSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListButtonSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListViewSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuButtonSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuItemSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuPopupSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMeterSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraPaletteSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraPanoramaSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraPushButtonSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraRadioButtonSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraRollupSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraScrollBarSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraScrollPaneSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSheetSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSliderSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSpinnerSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSuggestionPopupSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTabPaneSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTableViewHeaderSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTableViewSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTextInputSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTheme.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTreeViewSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraVFSBrowserSkin.java
Transmitting file data .....................................done
Committing transaction...
Committed revision 1830117.
> Implement "checkstyle" for builds and make changes to bring code into better
> compliance
> ---------------------------------------------------------------------------------------
>
> Key: PIVOT-1032
> URL: https://issues.apache.org/jira/browse/PIVOT-1032
> Project: Pivot
> Issue Type: Improvement
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Attachments: 1032.diffs.txt
>
>
> I thought it would be interesting, in addition to the "trim-whitespace" task
> already implemented, to do some sort of "checkstyle" processing to evaluate
> all the code to see where there might be changes to make the code more robust
> and a better example of "canonical" Java style.
> I hesitate to expect that we could address everything (or indeed whether we
> *should*), but there might be things that would make the code better and
> easier to read and maintain, and wouldn't take much effort.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
