I want to say that a lot of code I don't think makes sense, but mine is too many modified and hard to create a separate PR
spnettec (via GitHub) <g...@apache.org> 于2023年2月23日周四 22:05写道： > > spnettec commented on code in PR #818: > URL: https://github.com/apache/plc4x/pull/818#discussion_r1115744723 > > > ########## > > plc4j/tools/connection-cache/src/main/java/org/apache/plc4x/java/utils/cache/LeasedPlcConnection.java: > ########## > @@ -51,13 +51,23 @@ public void run() { > > @Override > public synchronized void close() { > - // Make the connection unusable. > - connection = null; > - > + if(connectionContainer == null) { > + return; > + } > > Review Comment: > This is a bug. It should not throw an error. If you change usageTimer > from local variable to private variable i can canel the Time. But... I > still think the Timer is not necessary. So i don't do anyting. Just add > this code. > > > > -- > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org > > For queries about this service, please contact Infrastructure at: > us...@infra.apache.org > >
