spnettec commented on code in PR #818:
URL: https://github.com/apache/plc4x/pull/818#discussion_r1115459466
##########
plc4j/tools/connection-cache/src/main/java/org/apache/plc4x/java/utils/cache/LeasedPlcConnection.java:
##########
@@ -51,13 +51,23 @@ public void run() {
@Override
public synchronized void close() {
- // Make the connection unusable.
- connection = null;
-
+ if(connectionContainer == null) {
+ return;
+ }
Review Comment:
Close twice. eg: user close this connection but usageTimer will close it
again. It will cause nullpointexception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
