chrisdutz commented on code in PR #818:
URL: https://github.com/apache/plc4x/pull/818#discussion_r1115656432
##########
plc4j/tools/connection-cache/src/main/java/org/apache/plc4x/java/utils/cache/LeasedPlcConnection.java:
##########
@@ -66,7 +76,7 @@ public void connect() throws PlcConnectionException {
@Override
public boolean isConnected() {
if(connection == null) {
- throw new PlcRuntimeException("Error using leased connection after
returning it to the cache.");
+ return false;
Review Comment:
I would say that's a usecase particular to how you use PLC4X, however out
API shouldn't be optimized towards one particular usecase. I think
try-catch-blocks don't consume any noticable amount of resources. So I would
like to ask to to stick to using try-catch blocks and us keeping the API
coherent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
