chrisdutz commented on code in PR #818:
URL: https://github.com/apache/plc4x/pull/818#discussion_r1115455299
##########
plc4j/api/src/main/java/org/apache/plc4x/java/api/model/PlcTag.java:
##########
@@ -63,6 +63,10 @@ default PlcValueType getPlcValueType() {
return PlcValueType.NULL;
}
+ @JsonIgnore
+ default void setPlcValueType(PlcValueType plcValueType){
+ }
Review Comment:
Yes please ... as I mentioned, we should try to keep one PR separated from
the other ... we're already mixing up the Cache and the Timeouts (which I think
is ok as I think both are not controversial)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
