spnettec commented on code in PR #818:
URL: https://github.com/apache/plc4x/pull/818#discussion_r1115500266
##########
plc4j/tools/connection-cache/src/main/java/org/apache/plc4x/java/utils/cache/LeasedPlcConnection.java:
##########
@@ -66,7 +76,7 @@ public void connect() throws PlcConnectionException {
@Override
public boolean isConnected() {
if(connection == null) {
- throw new PlcRuntimeException("Error using leased connection after
returning it to the cache.");
+ return false;
Review Comment:
We use PLC4x to collect data for long term work. If the connection is closed
abnormally, I don’t want to always use the try catch method. If we use this to
detect that the connection is closed, we only need to borrow it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
