bmwiedemann commented on code in PR #411:
URL: https://github.com/apache/qpid-proton/pull/411#discussion_r1362755587
##########
python/ext_build.py:
##########
@@ -40,7 +40,9 @@
sources = []
extra = []
libraries = []
-for root, _, files in os.walk(proton_core_src):
+for root, dirs, files in os.walk(proton_core_src):
+ dirs.sort()
Review Comment:
If there were no dirs, you wouldn't need to use `os.walk` in the first place
but could use `sorted(os.listdir(dir))` or
`sorted(glob.glob('path/to/*.cpp'))`. But there is a [`object`
subdir](https://github.com/apache/qpid-proton/tree/main/c/src/core/object)
involved.
When you omit this part, it can still traverse dirs in random order, so I
added it for future-proofness in case a 2nd dir gets added there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
