astitcher commented on code in PR #411: URL: https://github.com/apache/qpid-proton/pull/411#discussion_r1364124796
########## python/ext_build.py: ########## @@ -40,7 +40,9 @@ sources = [] extra = [] libraries = [] -for root, _, files in os.walk(proton_core_src): +for root, dirs, files in os.walk(proton_core_src): + dirs.sort() Review Comment: I'd be very happy for you to add a comment stating that sorting the `files` list is necessary for reproducible builds. That would strongly suggest that if this code ever needs to use the `dirs` list in the future it should be sorted too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
