astitcher commented on code in PR #411: URL: https://github.com/apache/qpid-proton/pull/411#discussion_r1364120199
########## python/ext_build.py: ########## @@ -40,7 +40,9 @@ sources = [] extra = [] libraries = [] -for root, _, files in os.walk(proton_core_src): +for root, dirs, files in os.walk(proton_core_src): + dirs.sort() Review Comment: No, I literally mean that the variable `dirs` is never used and so sorting it is pointless. Indeed in the code you changed the variable `dirs` is not even there instead there is a placeholder `_`. To expand a little bit - the `os.walk` you mention generates a list of tuples` (root, dirs, files)` but the code in the loop never uses the `dirs` part of that tuple which is why in the original code there is only a placeholder `_`. I this clearer now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
