bmwiedemann commented on code in PR #411:
URL: https://github.com/apache/qpid-proton/pull/411#discussion_r1363111623


##########
python/ext_build.py:
##########
@@ -40,7 +40,9 @@
 sources = []
 extra = []
 libraries = []
-for root, _, files in os.walk(proton_core_src):
+for root, dirs, files in os.walk(proton_core_src):
+    dirs.sort()

Review Comment:
   For a test, you can try with
   ```bash
   #!/bin/sh
   for i in $(seq 5) ; do
    mkdir -p t/$i
    for j in $(seq 5) ; do
     touch t/$i/$i$j
    done
   done
   ```
   and then
   ```python
   #!/usr/bin/python3
   import os;
   
   for root, dirs, files in os.walk("t"):
       files.sort();
       #dirs.sort();
       print(files);
   ```
   which produced here on a ext4 filesystem:
   ```
   []
   ['11', '12', '13', '14', '15']
   ['31', '32', '33', '34', '35']
   ['21', '22', '23', '24', '25']
   ['51', '52', '53', '54', '55']
   ['41', '42', '43', '44', '45']
   ```
   
   So when you wrote "this code doesn't use dirs" you forgot the `os.walk` call 
itself that does use `dirs`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to