astitcher commented on code in PR #411: URL: https://github.com/apache/qpid-proton/pull/411#discussion_r1364464317
########## python/ext_build.py: ########## @@ -40,7 +40,9 @@ sources = [] extra = [] libraries = [] -for root, _, files in os.walk(proton_core_src): +for root, dirs, files in os.walk(proton_core_src): + dirs.sort() Review Comment: Huh, Are you saying that the output directory list is the same as the internal directory list of `os.walk` so that modifying it changes the order of the results from the `for` loop? Wow if so then leave the original code, but there has to be a comment to explain why the code is there as it looks like `dirs` is never used so the code to sort it is dead code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
