If we don't separate themes from the build for this release, it isn't that big
a deal, IMO. But if we do separate it out, it will impact the instructions on
how to build "everything" and releasecandidate.xml script will need updating as
well to include the new Maven profile otherwise versions will not be updated in
the theme poms.
My 2 cents,
-Alex
On 4/20/18, 9:35 AM, "Piotr Zarzycki" <piotrzarzyck...@gmail.com> wrote:
Alex,
I was considering this part from Carlos:
" If we do this, we should let people know that they must first build themes
and then build royale-asjs."
It looks like it is nothing what's actually impact Emulation. I did
understand it wrong.
Thanks,
Piotr
2018-04-20 17:53 GMT+02:00 Alex Harui <aha...@adobe.com.invalid>:
> Hi Piotr,
>
> What kinds of impact are you concerned about? I think Jewel should be
> independent of MXRoyale for now, although we may use Jewel as the default
> look for MXRoyale some day.
>
> Thanks,
> -Alex
>
> On 4/20/18, 4:46 AM, "Piotr Zarzycki" <piotrzarzyck...@gmail.com> wrote:
>
> Hi Alex,
>
> I'm also fine with release. Does Jewel module in general may affect
> build,
> for example Alina's build once Alex merge all ?
>
> Thanks,
> Piotr
>
> 2018-04-20 12:02 GMT+02:00 Carlos Rovira <carlosrov...@apache.org>:
>
> > Hi Alex,
> >
> > 2018-04-20 5:05 GMT+02:00 Alex Harui <aha...@adobe.com.invalid>:
> >
> > > So much for releasing early each month ;-)
> > >
> > >
> > yep! :)))
> >
> >
> > > I merged develop and uibase-classname branches into the MXRoyale
> branch.
> > > I'm thinking of merging MXRoyale into develop and cutting a
> release. We
> > > will likely continue creating new emulation components in MXRoyale
> since
> > > we are inviting new contributors so continuing work in MXRoyale
> will
> > > result in less breaking of the nightly builds.
> > >
> > > The emulation components are far from finished, but IMO, we should
> > release
> > > what we have. It shouldn't have impact on other component sets.
> What do
> > > others think?
> > >
> >
> > I think that's ok, I still could not take a look at MXRoyale, but I
> think
> > is a good time
> > to see what will be merged
> >
> >
> >
> > >
> > > The Jewel stuff seems to be working, but we might want to create a
> common
> > > base class for the new className/classList code in Jewel. Or it
> could
> > > wait until next month.
> > >
> >
> > For Jewel I think all is ok, after some days of trying themes stuff,
> we
> > should consider to remove "themes"
> > folder for building directly, and we could split it the same way as
> > "examples" (that are not build directly when we build royale-asjs).
> > If we do this, we should let people know that they must first build
> themes
> > and then build royale-asjs. Just a suggestion.
> >
> > Regarding to include JewelUIBase class, I'm for do it, but I think
> this
> > should not stop these release, since is something internal
> > Maybe I could have it done or not, I'm have many things on my plate
> and
> > don't know exactly how I'll be getting this done.
> >
> > So for me is ok to include MXRoyale and cutting a 0.9.3 release
> >
> > thanks
> >
> > Carlos
> >
> >
> >
> > > Anything else we need to add or remove from 0.9.3?
> > >
> > > Thoughts?
> > > -Alex
> > >
> > >
> > >
> > >
> >
> >
> > --
> > Carlos Rovira
> > https://na01.safelinks.protection.outlook.com/?url=
> http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%
> 7C8c072c418de345acbb0608d5a6b454c3%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C636598215807973526&sdata=3rxII8BoHbPEh6JmOXc9zpEBiiNMEc
> DpbYTZnkpJUaE%3D&reserved=0
> >
>
>
>
> --
>
> Piotr Zarzycki
>
> Patreon: *https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%
> 7Caharui%40adobe.com%7C8c072c418de345acbb0608d5a6b454c3%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636598215807973526&sdata=
> Nv3WhatXm0bNEuF0eOBzA1AL%2FBBVPsYuebaTNJXP55s%3D&reserved=0
> <https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%
> 7Caharui%40adobe.com%7C8c072c418de345acbb0608d5a6b454c3%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636598215807973526&sdata=
> Nv3WhatXm0bNEuF0eOBzA1AL%2FBBVPsYuebaTNJXP55s%3D&reserved=0>*
>
>
>
--
Piotr Zarzycki
Patreon:
*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cce31810f0e1c4d50f96a08d5a6dcb6f2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636598389259527566&sdata=R%2F0nOUkz6xx5CA6YGDz9yy4Z5EQfsNR7PXkB%2FUBgGMM%3D&reserved=0
<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cce31810f0e1c4d50f96a08d5a6dcb6f2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636598389259527566&sdata=R%2F0nOUkz6xx5CA6YGDz9yy4Z5EQfsNR7PXkB%2FUBgGMM%3D&reserved=0>*
