Hi Josh, I rebuild all in the branch and can confirm your fix worked :)
Thanks for taking the time check this and showing the way to fix it! :) Carlos El jue., 6 dic. 2018 a las 19:10, Carlos Rovira (<[email protected]>) escribió: > Hi Josh, > > thanks for looking at it, I'll going to check now and report > > El jue., 6 dic. 2018 a las 19:03, Josh Tynjala (<[email protected]>) > escribió: > >> Carlos, >> >> I wish that you had included the list of problems that you are seeing, as >> I requested. I wanted to be completely certain that I'm seeing the exact >> same ones that you are. >> >> Regardless, here's my initial attempt to reproduce and fix your issue. >> >> In examples/mxroyale/RemoteObjectAMFTest/asconfig.json, I switched to >> App_Jewel.mxml. >> >> Instead of using your branch, I simply modified royale-config.xml in my >> local SDK. When I did this, I saw the following problems appear in Visual >> Studio Code: >> >> App_Jewel.mxml(30): col: 20 Warning: Definition mx.rpc.AsyncToken could >> not be found. >> App_Jewel.mxml(31): col: 20 Warning: Definition mx.rpc.Responder could >> not be found. >> App_Jewel.mxml(32): col: 20 Warning: Definition mx.rpc.events.FaultEvent >> could not be found. >> App_Jewel.mxml(33): col: 20 Warning: Definition mx.rpc.events.ResultEvent >> could not be found >> App_Jewel.mxml(38): col: 33 Error: Type was not found or was not a >> compile-time constant: FaultEvent. >> App_Jewel.mxml(44): col: 31 Error: Type was not found or was not a >> compile-time constant: AsyncToken. >> App_Jewel.mxml(45): col: 35 Error: Type was not found or was not a >> compile-time constant: Responder. >> App_Jewel.mxml(48): col: 33 Error: Call to a possibly undefined method >> Responder. >> App_Jewel.mxml(54): col: 49 Error: Type was not found or was not a >> compile-time constant: ResultEvent. >> App_Jewel.mxml(70): col: 23 Error: Type was not found or was not a >> compile-time constant: Responder. >> App_Jewel.mxml(70): col: 39 Error: Call to a possibly undefined method >> Responder. >> App_Jewel.mxml(71): col: 23 Error: Type was not found or was not a >> compile-time constant: AsyncToken. >> App_Jewel.mxml(76): col: 55 Error: Type was not found or was not a >> compile-time constant: ResultEvent. >> App_Jewel.mxml(142): col: 23 Error: Type was not found or was not a >> compile-time constant: Responder. >> App_Jewel.mxml(142): col: 39 Error: Call to a possibly undefined method >> Responder. >> App_Jewel.mxml(143): col: 23 Error: Type was not found or was not a >> compile-time constant: AsyncToken. >> App_Jewel.mxml(148): col: 60 Error: Type was not found or was not a >> compile-time constant: ResultEvent. >> App_Jewel.mxml(170): col: 9 Error: This tag is unexpected. It will be >> ignored. >> >> These problems are expected, of course, since MXRoyaleJS.swc is not in >> the library path anymore. >> >> In asconfig.json, I added the following two compiler options: >> >> "library-path": [ >> "${royalelib}/js/libs/MXRoyaleJS.swc" >> ], >> "js-library-path": [ >> "${royalelib}/js/libs/MXRoyaleJS.swc" >> ] >> >> This cleared up all of the problems. Does this work for you? >> >> - Josh >> >> On 2018/12/06 10:05:36, Carlos Rovira <[email protected]> wrote: >> > Hi Josh >> > >> > El mié., 5 dic. 2018 a las 17:59, Josh Tynjala (<[email protected] >> >) >> > escribió: >> > >> > > Carlos, can you include more details about your issue? >> > > >> > > > MX RO test with Jewel >> > > >> > > Can you mention the exact project inside royale-asjs that I can load >> with >> > > VSCode to see this issue? I'm guessing that it might be one of the >> > > RemoteObjectAMFTest projects, but there are more than one! >> > > >> > > >> > Check this one: >> > >> https://github.com/apache/royale-asjs/blob/develop/examples/mxroyale/RemoteObjectAMFTest/pom.xml >> > >> > but notice that App setup by default is not the right one (check lines >> 49 >> > and 50 here): >> > >> > >> https://github.com/apache/royale-asjs/blob/develop/examples/mxroyale/RemoteObjectAMFTest/pom.xml >> > >> > You must use "App_Jewel.mxml" >> > >> > Remember to use "feature/refactor-config-name-changes" branch where my >> > commit is reverted and things are set up like Alex want. >> > >> > You should try to make another config (for example: >> > "jewel-config-template.xml") that can pick up Jewel and MXRoyale SWCs >> > and VSCode and your extension should not show any errors. >> > >> > >> > >> > > > Results: you should see the problems in VSCode >> > > >> > > Can you list the exact problems that you are seeing in VSCode? I'd >> like to >> > > make sure that I'm not running into unrelated issues. >> > > >> > >> > With Alex changes all classes coming from MXRoyale are not recognized >> hence >> > show error. >> > If I try to make a new config file and add MXRoyale, rebuild all and SDK >> > too, reopen VSCode, nothing changes >> > >> > So my bet is that there's some issue in Royale that makes this new >> config >> > changes not work far beyond the special configuration Alex did and need >> to >> > find where is the issue. Other possibility is that VSCode extension is >> > failing, but since it already loads different configs, this seems more >> > strange to me, although possible. >> > >> > >> > > >> > > I don't think that this is an issue with VSCode or with the changes >> that >> > > Alex made. I suspect that it's just some configuration changes that >> are >> > > needed. >> > > >> > > - Josh >> > > >> > >> > Thanks for looking into this Josh >> > >> > -- >> > Carlos Rovira >> > http://about.me/carlosrovira >> > >> > > > -- > Carlos Rovira > http://about.me/carlosrovira > > -- Carlos Rovira http://about.me/carlosrovira
