I went back through versions.props and I think there are only two that can
be removed:

commons-text - https://github.com/apache/solr/pull/1539 - this one is simple
joda-time - https://github.com/apache/solr/pull/1540 - this one is slightly
more complicated

But out of the 76 lines we define only having two is pretty good.

Kevin Risden


On Mon, Apr 3, 2023 at 4:49 PM Jan Høydahl <jan....@cominvent.com> wrote:

> This PR will allow comments in versions.props:
> https://github.com/apache/solr/pull/1537, as long as the rest of the
> lines are sorted...
>
> Jan
>
> > 3. apr. 2023 kl. 22:09 skrev David Smiley <dsmi...@apache.org>:
> >
> > gradle/validation/versions-props-sorted.gradle
> > -- will fail if you add a comment to this file.
>
>

Reply via email to