Should it be an error? > On Jan 22, 2024, at 2:35 PM, Jason Gerlowski <gerlowsk...@gmail.com> wrote: > >> I'm a little surprised that this isn't caught by the > 'check'/'precommit' checks - I've been relying (apparently mistakenly) on > those tasks to catch this sort of thing when reviewing and merging PRs. > > Ah, I see why I didn't catch it. It's a warning instead of an error. > Nevermind my comment. Working on a fix now. > > On Mon, Jan 22, 2024 at 2:32 PM Jason Gerlowski <gerlowsk...@gmail.com> > wrote: > >> I've put together a first-draft for our release-notes for 9.5. They're >> available here: >> https://cwiki.apache.org/confluence/display/SOLR/DRAFT+ReleaseNote9_5_0 >> >> Would love some review on what I've put together; feel free to add, remove >> or change anything as needed! >> >> Best, >> >> Jason >> >> On Mon, Jan 22, 2024 at 2:18 PM Jason Gerlowski <gerlowsk...@gmail.com> >> wrote: >> >>>> I committed a bug in the build for setting up Node with a registry >>> mirror. I assume it's ok for me to backport? >>> >>> Yep, please do! >>> >>>> One page has two of the same anchors on branch_9x and branch_9_5. We >>> should fix this before the release. >>> >>> Agreed, I'll take a look. >>> >>> Fwiw, I merged the PR that likely created that anchor conflict. I'm a >>> little surprised that this isn't caught by the 'check'/'precommit' checks - >>> I've been relying (apparently mistakenly) on those tasks to catch this sort >>> of thing when reviewing and merging PRs. I guess I'll have to add some >>> other ref-guide specific task to my pre-merge routine? >>> >>> On Mon, Jan 22, 2024 at 1:29 PM Houston Putman <hous...@apache.org> >>> wrote: >>> >>>> Hey Jason, >>>> >>>> I committed a bug in the build for setting up Node with a registry >>>> mirror. >>>> I assume it's ok for me to backport? >>>> >>>> Also I noticed that there is an issue with the ref guide. One page has >>>> two >>>> of the same anchors on branch_9x and branch_9_5. We should fix this >>>> before >>>> the release. >>>> >>>> >>>> {"level":"warn","time":1705948125542,"name":"asciidoctor","file":{"path":"/Users/houstonputman/dev/oss/solr/solr/main/solr/solr-ref-guide/build/site-staging/modules/configuration-guide/pages/coreadmin-api.adoc","line":606},"source":{"url":"file:///Users/houstonputman/dev/oss/solr/solr/main","local":"/Users/houstonputman/dev/oss/solr/solr/main/.git","worktree":"/Users/houstonputman/dev/oss/solr/solr/main","refname":"branch_9_5","reftype":"branch","startPath":"solr/solr-ref-guide/build/site-staging"},"msg":"id >>>>> assigned to block already in use: v1coreadmin-mergeindexes"} >>>>> >>>> {"level":"warn","time":1705948125542,"name":"asciidoctor","file":{"path":"/Users/houstonputman/dev/oss/solr/solr/main/solr/solr-ref-guide/build/site-staging/modules/configuration-guide/pages/coreadmin-api.adoc","line":614},"source":{"url":"file:///Users/houstonputman/dev/oss/solr/solr/main","local":"/Users/houstonputman/dev/oss/solr/solr/main/.git","worktree":"/Users/houstonputman/dev/oss/solr/solr/main","refname":"branch_9_5","reftype":"branch","startPath":"solr/solr-ref-guide/build/site-staging"},"msg":"id >>>>> assigned to block already in use: v2coreadmin-mergeindexes"} >>>>> >>>> >>>> - Houston >>>> >>>> On Mon, Jan 22, 2024 at 12:30 PM Jason Gerlowski <gerlowsk...@gmail.com> >>>> wrote: >>>> >>>>> NOTICE: >>>>> >>>>> Branch branch_9_5 has been cut and versions updated to 9.6 on the >>>> stable >>>>> branch. >>>>> >>>>> Please observe the normal rules: >>>>> >>>>> * No new features may be committed to the branch. >>>>> * Documentation patches, build patches and serious bug fixes may be >>>>> committed to the branch. However, you should submit all patches you >>>>> want to commit to Jira first to give others the chance to review >>>>> and possibly vote against the patch. Keep in mind that it is our >>>>> main intention to keep the branch as stable as possible. >>>>> * All patches that are intended for the branch should first be >>>> committed >>>>> to the unstable branch, merged into the stable branch, and then into >>>>> the current release branch. >>>>> * Normal unstable and stable branch development may continue as usual. >>>>> However, if you plan to commit a big change to the unstable branch >>>>> while the branch feature freeze is in effect, think twice: can't the >>>>> addition wait a couple more days? Merges of bug fixes into the branch >>>>> may become more difficult. >>>>> * Only Jira issues with Fix version 9.5 and priority "Blocker" will >>>> delay >>>>> a release candidate build. >>>>> >>>>> The feature-freeze for the 9.5 release will go till the end of this >>>> week - >>>>> I'll aim to create our first RC on Thursday, January 25th. >>>>> >>>>> Best, >>>>> >>>>> Jason >>>>> >>>> >>>
_______________________ Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | http://www.opensourceconnections.com <http://www.opensourceconnections.com/> | My Free/Busy <http://tinyurl.com/eric-cal> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw> This e-mail and all contents, including attachments, is considered to be Company Confidential unless explicitly stated otherwise, regardless of whether attachments are marked as such.
