Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2234
@omerhadari I don't think you need to fix all violations for the module,
but of course wouldn't complain if you did ;) If you do I think it should go in
another PR though.
Check the pom.xml for storm-jms. It has a count of ignored violations If
the build fails now it's because the diff here adds some new checkstyle
violations. If you build storm-jms locally, you should get a
checkstyle-violations.xml in storm-jms/target. I think it would be good to
either fix the new violations (check out master and diff checkstyle-violations
with yours), or just fix all violations for the two modified files. If you're
up for fixing the violations for the two files, please reduce the number of
ignored errors in pom.xml to match.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
