Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2234#discussion_r128850623
--- Diff:
external/storm-jms/src/main/java/org/apache/storm/jms/spout/JmsSpout.java ---
@@ -250,10 +341,17 @@ public void nextTuple() {
}
- /*
- * Will only be called if we're transactional or not AUTO_ACKNOWLEDGE
+ /**
+ * Ack a successfully handled message by the matching {@link
JmsMessageID}.
+ *
+ * <p>Acking means removing the message from the pending messages
+ * collections,and if it was the oldest pending message -
--- End diff --
Nit: Missing space at the comma
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
