Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2234#discussion_r128849355
--- Diff:
external/storm-jms/src/main/java/org/apache/storm/jms/spout/JmsSpout.java ---
@@ -205,6 +277,12 @@ public void open(Map<String, Object> conf,
TopologyContext context,
}
+ /**
+ * Close the {@link #session} and {@link #connection}.
+ *
+ * <p>When overridden, should always call {@code super} for handling
the
--- End diff --
Nit: call `{@code super}` to finalize the active connections
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
