Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2234#discussion_r128850697
--- Diff:
external/storm-jms/src/main/java/org/apache/storm/jms/spout/JmsSpout.java ---
@@ -268,18 +366,25 @@ public void ack(Object msgId) {
LOG.warn("Error acknowldging JMS message: " + msgId,
e);
}
} else {
- LOG.warn("Couldn't acknowledge unknown JMS message ID: " +
msgId);
+ LOG.warn("Couldn't acknowledge unknown JMS message ID: "
+ + msgId);
}
} else {
this.toCommit.remove(msgId);
}
}
- /*
- * Will only be called if we're transactional or not AUTO_ACKNOWLEDGE
+ /**
+ * Fail an unsuccessfully handled message by the its {@link
JmsMessageID}.
--- End diff --
Nit: the its
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
