Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2234#discussion_r128852007
  
    --- Diff: 
external/storm-jms/src/main/java/org/apache/storm/jms/spout/JmsSpout.java ---
    @@ -352,27 +478,46 @@ private static final String toDeliveryModeString(int 
deliveryMode) {
             }
         }
     
    +    /**
    +     * @return The currently active session.
    +     */
         protected Session getSession() {
             return this.session;
         }
     
    +    /**
    +     * Check if there is a pending messages state.
    --- End diff --
    
    Nit: Rephrase as Check if the subscription requires messages to be acked. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to