Github user omerhadari commented on a diff in the pull request:
https://github.com/apache/storm/pull/2234#discussion_r128855869
--- Diff:
external/storm-jms/src/main/java/org/apache/storm/jms/spout/JmsSpout.java ---
@@ -72,19 +72,18 @@
private static final Logger LOG =
LoggerFactory.getLogger(JmsSpout.class);
/** The logger of the recovery task. */
- private static final Logger RECOVERY_TASK_LOG =
- LoggerFactory.getLogger(RecoveryTask.class);
+ private static final Logger RECOVERY_TASK_LOG =
LoggerFactory.getLogger(RecoveryTask.class);
/** Time to sleep between queue polling attempts. */
- private static final int POLL_INTERVAL = 50;
+ private static final int POLL_INTERVAL_MS = 50;
/**
- * The default value the {@link Config#TOPOLOGY_MESSAGE_TIMEOUT_SECS}.
+ * The default value for {@link Config#TOPOLOGY_MESSAGE_TIMEOUT_SECS}.
*/
- private static final int DEFAULT_MESSAGE_TIMEOUT = 30;
+ private static final int DEFAULT_MESSAGE_TIMEOUT_SECS = 30;
- /** Time to wait before queuing the first recovery task (in seconds).
*/
- private static final int RECOVERY_DELAY = 10;
+ /** Time to wait before queuing the first recovery task. */
+ private static final int RECOVERY_DELAY_SECS = 10;
--- End diff --
Right, nice catch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
