[GitHub] storm pull request #2754: STORM-3133: Extend metrics on Nimbus and LogViewer

[srdo]

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2754#discussion_r209047681
  
    --- Diff: 
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
 ---
    @@ -52,7 +55,7 @@
     /**
      * The main entry of Logviewer.
      */
    -public class LogviewerServer implements AutoCloseable {
    +public class LogviewerServer implements AutoCloseable, MetricSet {
    --- End diff --
    
    This seems like an odd choice. Why doesn't ExceptionMeters implement 
MetricSet instead, LogviewerServer is not a MetricSet?


---