Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209074521
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -253,12 +276,11 @@ private long lastModifiedTimeWorkerLogdir(File
logDir) {
return curr > maximum ? curr : maximum;
}, BinaryOperator.maxBy(Long::compareTo));
} catch (Exception ex) {
+ //This is not IOException
--- End diff --
I feel like this comment will become out of date as soon as someone starts
writing new code inside the try block. Also it's not obvious why it's here
outside the context of this PR. I'd remove it.
---
