[GitHub] storm pull request #2754: STORM-3133: Extend metrics on Nimbus and LogViewer

[srdo]

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2754#discussion_r209077210
  
    --- Diff: 
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
 ---
    @@ -255,8 +302,16 @@ public Response deepSearch(@PathParam("topoId") String 
topologyId,
             String callback = 
request.getParameter(StormApiResource.callbackParameterName);
             String origin = request.getHeader("Origin");
     
    -        return logSearchHandler.deepSearchLogsForTopology(topologyId, 
user, searchString, numMatchesStr, portStr,
    -                startFileOffset, startByteOffset, 
BooleanUtils.toBooleanObject(searchArchived), callback, origin);
    +        Boolean alsoSearchArchived = 
BooleanUtils.toBooleanObject(searchArchived);
    --- End diff --
    
    Doesn't this belong in deepSearchLogsForTopology rather than here?


---