Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209079357
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/ExceptionMeters.java
---
@@ -0,0 +1,66 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements.
+ * See the NOTICE file distributed with this work for additional
information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
(the "License");
+ * you may not use this file except in compliance with the License. You
may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an "AS IS"
BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
limitations under the License.
+ */
+
+package org.apache.storm.daemon.logviewer.utils;
+
+import com.codahale.metrics.Meter;
+import com.codahale.metrics.Metric;
+import com.codahale.metrics.MetricSet;
+
+import java.util.HashMap;
+import java.util.Map;
+
+public enum ExceptionMeters {
+ //Operation level IO Exceptions
+ NUM_FILE_OPEN_EXCEPTIONS("logviewer:num-file-open-exceptions"),
--- End diff --
Why is it useful to distinguish between e.g. read and open errors in the
metrics?
---
