On Thu, Mar 12, 2015 at 10:24 PM, Reka Thirunavukkarasu <r...@wso2.com>
wrote:
> Hi Lahiru/Raj,
>
> I think that we have introduced this *cartridgeMin/**cartridgeMax *when
> introducing the deployment policy for cartridge and groups as global
> deployment policy. Since we have the same concept now, i would like to
> review the implementation and confirm whether it is required or not. Can
> you please hold until that? I will quickly confirm on this..
>
Hi Reka, I am not sure whether I understood you wrong. Yes we need
cartridgeMin and cartridgeMax, which are defined in application json. But
we don't need *maxInstanceLimit* property, which used to define in
cartridge json in 4.0.0. I guess we have already removed references to this
property from code base, but not from sample artifacts.
Thanks.
>
> Thanks,
> Reka
>
> On Thu, Mar 12, 2015 at 9:40 AM, Lahiru Sandaruwan <lahi...@wso2.com>
> wrote:
>
>> Noticed today. It was misleading as we have this left in samples. I will
>> clean this up.
>>
>> Thanks.
>>
>> On Thu, Mar 12, 2015 at 10:04 PM, Rajkumar Rajaratnam <rajkum...@wso2.com
>> > wrote:
>>
>>> Hi Devs,
>>>
>>> We are defining cartridge min max count in application definition.
>>>
>>> {
>>> "applicationId": "single-cartridge-app",
>>> "alias": "single-cartridge-app",
>>> "multiTenant": false,
>>> "components": {
>>> "cartridges": [
>>> {
>>> "type": "php",
>>>
>>> *"cartridgeMin": 1, "cartridgeMax": 10,*
>>> "subscribableInfo": {
>>> "alias": "my-php",
>>> "autoscalingPolicy": "autoscaling-policy-1",
>>> "deploymentPolicy": "deployment-policy-1",
>>> "artifactRepository": {
>>> "privateRepo": false,
>>> "repoUrl": "
>>> https://github.com/imesh/stratos-php-applications.git";,
>>> "repoUsername": "",
>>> "repoPassword": ""
>>> }
>>> }
>>> }
>>> ]
>>> }
>>> }
>>>
>>> In 4.0.0, we used to define these in cartridge definition, in IaaS
>>> provider section. We have now removed it from cartridge bean classes.
>>> However I can see that samples still have this attribute. I will remove it.
>>>
>>> Thanks.
>>>
>>> --
>>> Rajkumar Rajaratnam
>>> Committer & PMC Member, Apache Stratos
>>> Software Engineer, WSO2
>>>
>>> Mobile : +94777568639
>>> Blog : rajkumarr.com
>>>
>>
>>
>>
>> --
>> --
>> Lahiru Sandaruwan
>> Committer and PMC member, Apache Stratos,
>> Senior Software Engineer,
>> WSO2 Inc., http://wso2.com
>> lean.enterprise.middleware
>>
>> phone: +94773325954
>> email: lahi...@wso2.com blog: http://lahiruwrites.blogspot.com/
>> linked-in: http://lk.linkedin.com/pub/lahiru-sandaruwan/16/153/146
>>
>>
>
>
> --
> Reka Thirunavukkarasu
> Senior Software Engineer,
> WSO2, Inc.:http://wso2.com,
> Mobile: +94776442007
>
>
>
--
Rajkumar Rajaratnam
Committer & PMC Member, Apache Stratos
Software Engineer, WSO2
Mobile : +94777568639
Blog : rajkumarr.com
