On Mon, Jul 12, 2021 at 2:15 PM Daniel Sahlberg
<daniel.l.sahlb...@gmail.com> wrote:
>
> Den mån 12 juli 2021 kl 18:16 skrev Nathan Hartman <hartman.nat...@gmail.com>:
>>
>> [...]
>>
>> These fixes have solved that issue; however pages that have
>> <pre>...</pre> formatted text cause the viewport to stretch when the
>> lines of text are longer than can fit in the viewport. On some pages
>> there are some quite long lines of preformatted text. Adding a
>> "overflow-x: auto;" to the CSS for pre tags in site.css seems to fix
>> it without affecting readability: It allows the pre tag itself to
>> scroll if needed, but the rest of the page stays put; e.g.,:
>>
>> [[[
>>
>> Index: style/site.css
>> ===================================================================
>> --- style/site.css (revision 1891484)
>> +++ style/site.css (working copy)
>> @@ -54,6 +54,7 @@ pre {
>> padding: 0.25em;
>> margin: 0 2em;
>> font-size: 90%;
>> + overflow-x: auto;
>> }
>>
>> /*
>>
>> ]]]
>
>
> Good catch! Your patch seems fine to me. I committed to check on the staging
> site and it looks good both on my computer and in my phone.
This is in fact a big improvement and most pages are behaving nicely
now. However I noticed that there exist some other elements besides
<pre>..</pre> that are extending the viewport in a few places. One
example of this is the mailing list page [1] where the table does it;
another is the faq where one entry's title is extending the page width
[2]. There are a few other places where one or two elements do it. I
haven't yet looked into what the fix needs to be. It might be as
simple as moving the "overflow-x: auto" to a different place. Other
than this, the site altogether is well-behaved and much improved on
mobile.
[1] http://subversion-staging.apache.org/mailing-lists.html
[2] http://subversion-staging.apache.org/faq.html#configure-sed-error
Nathan
