Github user becrux commented on a diff in the pull request:
https://github.com/apache/thrift/pull/628#discussion_r45579441
--- Diff: lib/cpp/src/thrift/windows/GetTimeOfDay.cpp ---
@@ -23,17 +23,28 @@
// win32
#include <time.h>
+#if defined(__MINGW32__)
+ #include <sys/time.h>
+#endif
+
#if defined(_MSC_VER) || defined(_MSC_EXTENSIONS)
#define DELTA_EPOCH_IN_MICROSECS 11644473600000000Ui64
#else
#define DELTA_EPOCH_IN_MICROSECS 11644473600000000ULL
#endif
+#if !defined(__MINGW32__)
struct timezone {
int tz_minuteswest; /* minutes W of Greenwich */
int tz_dsttime; /* type of dst correction */
};
+#endif
--- End diff --
Yes, I can merge it, you're right.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
