[
https://issues.apache.org/jira/browse/THRIFT-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15108661#comment-15108661
]
ASF GitHub Bot commented on THRIFT-3560:
----------------------------------------
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/798#issuecomment-173229082
Implementation aside, this change breaks users' existing custom transports,
although mostly in trivial ways.
What is your (hypothetical) use case(s) with this or peek const change ?
Would this make the API more usable ?
> C++ TTransport::isOpen() and TTransport::getOrigin() should be const member
> functions
> -------------------------------------------------------------------------------------
>
> Key: THRIFT-3560
> URL: https://issues.apache.org/jira/browse/THRIFT-3560
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.9.3, 0.9.4, 1.0
> Reporter: Sebastian Zenker
> Priority: Minor
> Labels: easyfix
>
> ... as they should not alter the state of TTransport. Also peek() should be
> const in my opinion, but this requires some more refactoring.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
