[ https://issues.apache.org/jira/browse/THRIFT-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15108708#comment-15108708 ]
ASF GitHub Bot commented on THRIFT-3560: ---------------------------------------- Github user hcorg commented on the pull request: https://github.com/apache/thrift/pull/798#issuecomment-173236675 if it's a breaking change maybe we should put is as part of cpp_v2 developement? We could use override and other C++11 features to help users migrate. > C++ TTransport::isOpen() and TTransport::getOrigin() should be const member > functions > ------------------------------------------------------------------------------------- > > Key: THRIFT-3560 > URL: https://issues.apache.org/jira/browse/THRIFT-3560 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library > Affects Versions: 0.9.3, 0.9.4, 1.0 > Reporter: Sebastian Zenker > Priority: Minor > Labels: easyfix > > ... as they should not alter the state of TTransport. Also peek() should be > const in my opinion, but this requires some more refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)