[
https://issues.apache.org/jira/browse/THRIFT-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15108702#comment-15108702
]
ASF GitHub Bot commented on THRIFT-3560:
----------------------------------------
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/798#issuecomment-173236071
I'm a fan of const correctness. We shouldn't penalize const correctness
due to an inherent weakness in the language (that was resolved in C++11, i.e.
the [override operator](http://en.cppreference.com/w/cpp/language/override)).
I agree this would be something to list as part of a release's "breaking
changes" which would affect customer created subclasses.
> C++ TTransport::isOpen() and TTransport::getOrigin() should be const member
> functions
> -------------------------------------------------------------------------------------
>
> Key: THRIFT-3560
> URL: https://issues.apache.org/jira/browse/THRIFT-3560
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.9.3, 0.9.4, 1.0
> Reporter: Sebastian Zenker
> Priority: Minor
> Labels: easyfix
>
> ... as they should not alter the state of TTransport. Also peek() should be
> const in my opinion, but this requires some more refactoring.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
