[
https://issues.apache.org/jira/browse/THRIFT-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109546#comment-15109546
]
ASF GitHub Bot commented on THRIFT-3560:
----------------------------------------
Github user hcorg commented on the pull request:
https://github.com/apache/thrift/pull/798#issuecomment-173373046
@szenker pull requests are welcome :) right now I'm trying to revive my old
branch (I'm porting some changes done to cpp lib into cpp_v2), currently it
might not even compile :/ but c++11/14 is something I really want to enable for
thrift. std::future for asynchronous tasks.. std::optional for optionals
(c++17, but still :) ). I'll try to set up some discussion on dev@ mailing list
later this week/weekend so we might split some tasks etc.
> C++ TTransport::isOpen() and TTransport::getOrigin() should be const member
> functions
> -------------------------------------------------------------------------------------
>
> Key: THRIFT-3560
> URL: https://issues.apache.org/jira/browse/THRIFT-3560
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.9.3, 0.9.4, 1.0
> Reporter: Sebastian Zenker
> Priority: Minor
> Labels: easyfix
>
> ... as they should not alter the state of TTransport. Also peek() should be
> const in my opinion, but this requires some more refactoring.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
