[
https://issues.apache.org/jira/browse/THRIFT-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110036#comment-15110036
]
ASF GitHub Bot commented on THRIFT-3560:
----------------------------------------
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/798#issuecomment-173449026
I posted a C# runtime rewrite about 5 years ago that allowed for two way
communication and multiple outstanding requests with out-of-order replies using
the sequence number in the binary V1 header... it also had multiple channel
support similar to the multiplexing protocol except I built it into the binary
protocol. It is in Apache Jira under THRIFT-66. Perhaps you can leverage some
concepts from that work.
As for the const correctness issue, I'm okay with the proposed changes
going into the current implementation.
> C++ TTransport::isOpen() and TTransport::getOrigin() should be const member
> functions
> -------------------------------------------------------------------------------------
>
> Key: THRIFT-3560
> URL: https://issues.apache.org/jira/browse/THRIFT-3560
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.9.3, 0.9.4, 1.0
> Reporter: Sebastian Zenker
> Priority: Minor
> Labels: easyfix
>
> ... as they should not alter the state of TTransport. Also peek() should be
> const in my opinion, but this requires some more refactoring.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
