[
https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369198#comment-15369198
]
James E. King, III commented on THRIFT-3873:
--------------------------------------------
[~jensg] One of the 23 Travis jobs timed out at 48 minutes but it looks like it
had passed all its tests and was in the middle of make cross. Is there a way
to rebuild one of those jobs? Would you consider merging it given it passed
almost all the tests, and the build environment is to blame for the single
failed test? It does need a code review. There were issues with integer
conversions relating to 64-bit pointer manipulation. Much of the code in
transport uses 32-bit integers for sizes. What I did in these cases was to add
an assert to ensure the pointer calculation was within the proper range before
casting it. I couldn't convince myself that moving all the code in transport
to 64-bit would be the right thing to do for this project, since I assume we
have plenty of folks using thrift in embedded 32-bit processors... although I
would expect those environments to provide 64-bit support it might not be as
fast.
> Fix various compiler warnings when using VS2010
> -----------------------------------------------
>
> Key: THRIFT-3873
> URL: https://issues.apache.org/jira/browse/THRIFT-3873
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.10.0
> Environment: VS2010, Windows
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Trivial
>
> While verifying a defect I had to build the windows thrift C++ library and
> found a number of compiler warnings that needed to be cleaned up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
