[ 
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124973#comment-16124973
 ] 

Can Celasun commented on THRIFT-4285:
-------------------------------------

I didn't have a chance to review the patch yet, but I really like the idea. 
Generated clients contain a lot of cruft that don't need to be there and 
getting rid of that and adding flexibilty in the process might be worth a BC 
break (though it might be too late for 0.11).

I'll have more feedback after reviewing the patch and making sure all tests are 
passing.

> Pull generated send/recv into library to allow behaviour to be customised
> -------------------------------------------------------------------------
>
>                 Key: THRIFT-4285
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4285
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Go - Compiler, Go - Library
>            Reporter: Chris Bannister
>            Assignee: Chris Bannister
>         Attachments: 0001-go-pull-generated-send-recv-into-lib.patch
>
>
> Currently it is difficult to change how thrift writes messages onto the 
> transport because they are in the generated code. Instead the generated 
> send/recv methods should be in the library. This will greatly simplify the 
> client code and remove many duplicate methods whilst allowing users more 
> flexibility to implement connection pools and other features such as THeader.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to