[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145048#comment-16145048
]
Can Celasun commented on THRIFT-4285:
-------------------------------------
Tried running the tests, there are some failures:
{code}
gopath/src/tests/client_error_test.go:414: undefined:
errortest.NewErrorTestClientProtocol
gopath/src/tests/client_error_test.go:446: undefined:
errortest.NewErrorTestClientProtocol
gopath/src/tests/client_error_test.go:567: undefined:
errortest.NewErrorTestClientProtocol
gopath/src/tests/client_error_test.go:610: undefined:
errortest.NewErrorTestClientProtocol
gopath/src/tests/client_error_test.go:640: undefined:
errortest.NewErrorTestClientProtocol
gopath/src/tests/client_error_test.go:670: undefined:
errortest.NewErrorTestClientProtocol
gopath/src/tests/multiplexed_protocol_test.go:71: undefined:
multiplexedprotocoltest.NewFirstClientProtocol
gopath/src/tests/multiplexed_protocol_test.go:85: undefined:
multiplexedprotocoltest.NewSecondClientProtocol
gopath/src/tests/multiplexed_protocol_test.go:97: undefined:
multiplexedprotocoltest.NewSecondClientProtocol
gopath/src/tests/multiplexed_protocol_test.go:145: firstClient.Transport
undefined (type *multiplexedprotocoltest.FirstClient has no field or method
Transport)
gopath/src/tests/multiplexed_protocol_test.go:145: too many errors
{code}
See full CI logs here: https://travis-ci.org/dcelasun/thrift/builds/269512983
> Pull generated send/recv into library to allow behaviour to be customised
> -------------------------------------------------------------------------
>
> Key: THRIFT-4285
> URL: https://issues.apache.org/jira/browse/THRIFT-4285
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Compiler, Go - Library
> Reporter: Chris Bannister
> Assignee: Chris Bannister
> Attachments: 0001-go-pull-generated-send-recv-into-lib-v6.patch
>
>
> Currently it is difficult to change how thrift writes messages onto the
> transport because they are in the generated code. Instead the generated
> send/recv methods should be in the library. This will greatly simplify the
> client code and remove many duplicate methods whilst allowing users more
> flexibility to implement connection pools and other features such as THeader.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
