[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187710#comment-16187710
]
ASF GitHub Bot commented on THRIFT-4285:
----------------------------------------
GitHub user dcelasun opened a pull request:
https://github.com/apache/thrift/pull/1381
THRIFT-4285: Move TX/RX methods from gen. code to library
This change removes a lot of duplication from generated code and allows the
caller to customize how they can read from / write to the transport.
This patch was originally written by [Chris
Bannister](https://issues.apache.org/jira/browse/THRIFT-4285) but it seemed
abandoned and no longer applied cleanly to master. I fixed it in order to get
things moving again.
It would be great if we can get this in before 0.11 is tagged.
Client: Go
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dcelasun/thrift THRIFT-4285
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1381.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1381
----
commit 0e03968520db377bce9f85caf55d7a218f9d59d5
Author: D. Can Celasun <c...@dcc.im>
Date: 2017-09-21T13:21:00Z
THRIFT-4285 Move TX/RX methods from gen. code to library
This change removes a lot of duplication from generated code and allows
the caller to customize how they can read from / write to the
transport.
Client: Go
----
> Pull generated send/recv into library to allow behaviour to be customised
> -------------------------------------------------------------------------
>
> Key: THRIFT-4285
> URL: https://issues.apache.org/jira/browse/THRIFT-4285
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Compiler, Go - Library
> Reporter: Chris Bannister
> Assignee: Chris Bannister
> Attachments: 0001-go-pull-generated-send-recv-into-lib-v6.patch,
> 0001-go-pull-generated-send-recv-into-lib-v7.patch
>
>
> Currently it is difficult to change how thrift writes messages onto the
> transport because they are in the generated code. Instead the generated
> send/recv methods should be in the library. This will greatly simplify the
> client code and remove many duplicate methods whilst allowing users more
> flexibility to implement connection pools and other features such as THeader.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
