We have a couple of other challenges in my opinion. Deps - all the shading is a pain but also takes a significant amount of time Examples - they are somehow also some testing code for our server, but they take time TCK - more and more TCK are now standalone and we can run them easily. As a result we do run CDI, BVal and all microprofile TCK for many flavors. Should we have a specific TCK build triggered once per day unless we are actively working on the project? Should we have the same approach as the full platform TCK? Webapps - aside from the disk space all the WAR manipulation to build the drop in war jars, then build the zip, unzip the webapps, copy the jars is heavy and a long process
I can't measure without investing a lot of time, but looking at what Maven reports CDI + BVal TCK around 25 min MicroProfile TCK 2 hours and a half Building TomEE and all the webapps, around 10 min All examples 10 mins Deps around 5 mins The entire build takes almost 6 hours -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Mon, Oct 10, 2022 at 9:58 PM David Blevins <david.blev...@gmail.com> wrote: > > On Oct 10, 2022, at 12:50 PM, Zowalla, Richard < > richard.zowa...@hs-heilbronn.de> wrote: > > > > Hi, > > > > The INFRA docs [1] do not mention any constraint that the PR needs to > > come from the same repository. > > > > It is also a problem, that we need to rely on different versions of > > Java based on a given branch, i.e. Java 8 for 8.x and Java 11 for 9.x, > > etc - there is no easy way to decide which one to use for the naive PR > > builder job. > > > > It might be possible, that there is a restriction regarding the GitHub > > Apache org members due to security concerns? > > > > For example: https://github.com/apache/tomee/pull/782 did build on the > > PR builder but the branch did not reside inside the ASF repo but was > > located in my fork. > > I checked the build definition and it looks like we're just keeping max 3 > builds for 2 days, so possibly (likely) other builds were there and deleted > before I could notice them. > > Looks like we have the clean workspace post-build step to delete the big > files. I added *.war to that and did a run locally with the same settings > to see how it affected our size. The workspace goes from 2.5GB to 262MB, > which is great so I upped our max builds to 10 and retention to 20 days. > > We'll see if that helps. Definitely we're not merging PRs in two days -- > usually more. > > Speaking of my own committing habits, I tend to push to main often. I'll > be trying to change that and do more PRs in hopes of not adding to the > build instability. Let's see how disciplined I can be in practice. :) > > If we all get in the habit of doing PRs, we could/should potentially > increase that max builds as it would effectively become the main CI job. > > > -David >
