Looks good to me: +1 I get a warning when building:
[WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.training:navigating-ASF-incubation:war:1.0.0-SNAPSHOT [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin com.coderplus.maven.plugins:copy-rename-maven-plugin @ line 304, column 21 [WARNING] [WARNING] It is highly recommended to fix these problems because they threaten the stability of your build. [WARNING] [WARNING] For this reason, future Maven versions might no longer support building such malformed projects. [WARNING] but that's not a blocker for a release. The only comment I have (but the +1 stands) is that this is a 1.0.0 release (with which I'm fine as well), I'm just not sure if patch & maintenance releases make much sense for content. I think releasing it as 1, 2, 3, etc. would be fine as well. On Tue, Jun 4, 2019 at 3:32 PM Lars Francke <[email protected]> wrote: > I'm sorry, I haven't gotten around to it yet either but it's on my list. > > On Tue, Jun 4, 2019 at 3:22 PM Justin Mclean <[email protected]> > wrote: > >> Hi, >> >> > can we extend the timeframe for voting? >> >> No need, i'st a minimum of 72 hours and hangs about until we get enough >> votes or decide to make a new release candidate. >> >> > I could check this release but I need more time since I'm new to this. >> > Usually, I check RCs by doing minimal testing, but I'd like to learn how >> > PMCs should check releases. >> >> The checklist I provided shod help but if you have any questions or >> unsure about anything just ask. It will also get checked by the IPMC so >> they may find something we miss. >> >> Thanks, >> Justin > >
