Please disregard question 2. from my previous email, I was just not reading the docs carefully enough :(
On Fri, 7 Jun 2019 at 21:46, Sönke Liebau <[email protected]> wrote: > Hi Justin, > > sorry for the long time it took, but I finally had a look at the release > candidate. > > Overall it looks good to me, I checked the signatures, built it and looked > at regulatory files. > > I do have two questions on the NOTICE and LICENSE file though: > > 1. in NOTICE there is a sentence that mentions that this content was > originally developed by you. Is that legally required to be there? I > absolutely don't want to remove your name from the material as original > author, but when looking at the Apache docs for assembling a NOTICE file it > said to not put anything in there that is not legally required [1], which > got me wondering. > > 2. At the bottom of the License file, there is a section that this project > contains parts of the reveal.js framework which is licensed under the MIT > license. Should that not be in the Notice file? In the docs I found the > following two sentences, which have me confused :) > "LICENSE should contain the text of the ALv2 -- no more, no less." [2] > "The LICENSE file communicates the licensing of all content in an Apache > product distribution. It always contains the text of the Apache License, > and sometimes more." [3] > > Probably both nits/non-issues, but wanted to briefly clarify. > > Best regards, > Sönke > > [1] http://www.apache.org/dev/licensing-howto.html#mod-notice > [2] http://www.apache.org/dev/licensing-howto.html#simple > [3] http://www.apache.org/dev/licensing-howto.html#overview-of-files > > On Fri, 7 Jun 2019 at 19:07, Lars Francke <[email protected]> wrote: > >> Hi Dmitriy, >> >> thanks for checking! >> >> The "your name" stuff came at my request. >> Justin had his personal details in there (e.g. Justin McLean, etc.) and in >> my opinion the material should be anonymous. Similar to code where we >> don't >> have any @author tags. >> So Justin removed the information. I'd be in favor of entirely removing >> those slides but I'm fine with the current solution as well. >> >> As to the other one: Just reading that sentence makes sense to me. I just >> looked at the slide and I think it's fine. >> Looking at the title of the slide "Why we have an incubating process" this >> one could begin with "To ensure" but I believe it's fine the way it is. >> >> The decision is yours but if that's everything you dislike I'd suggest we >> can fix/change it post-release. >> >> Cheers, >> Lars >> >> >> >> On Fri, Jun 7, 2019 at 5:44 PM Dmitriy Pavlov <[email protected]> wrote: >> >> > Hi, Justin, Training developers, >> > >> > +0.9 (PPMC Binding), >> > Checked license, notice readme and build from sources. >> > >> > I have only one remark. Generated slides in >> > >> > >> /apache-training-navigating-ASF-incubation-1.0-incubating/target/generated-slides/index.html >> > contain >> > The first slide contains: >> > ```Your Name >> > Your Job title >> > Your email``` >> > >> > The second slide contains >> > ```Who am I? >> > TODO Fill in your own your info here``` >> > >> > One from the next slide contains >> > ```Ensure that decision making is done in the open``` <- Phrase seems >> to be >> > incomplete. >> > >> > Sincerely >> > Dmitriy Pavlov >> > >> > пт, 7 июн. 2019 г. в 10:28, Justin Mclean <[email protected]>: >> > >> > > Hi, >> > > >> > > Thanks now we only need one more +1. Anyone? >> > > >> > > Thanks, >> > > Justin >> > > >> > > P.S I was hoping this talk was going to be accepted at ApacheCon but >> my >> > > other incubator talk got accepted instead. So looks like I have to >> work >> > on >> > > that and submit it here now ;-) >> > >> > > > -- > Sönke Liebau > Partner > Tel. +49 179 7940878 > OpenCore GmbH & Co. KG - Thomas-Mann-Straße 8 - 22880 Wedel - Germany > -- Sönke Liebau Partner Tel. +49 179 7940878 OpenCore GmbH & Co. KG - Thomas-Mann-Straße 8 - 22880 Wedel - Germany
