[ https://issues.apache.org/jira/browse/TWILL-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549823#comment-15549823 ]
ASF GitHub Bot commented on TWILL-195: -------------------------------------- Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/13#discussion_r82060058 --- Diff: twill-core/src/main/java/org/apache/twill/internal/EnvKeys.java --- @@ -22,36 +22,25 @@ */ public final class EnvKeys { - public static final String TWILL_ZK_CONNECT = "TWILL_ZK_CONNECT"; - public static final String TWILL_APP_RUN_ID = "TWILL_APP_RUN_ID"; public static final String TWILL_RUN_ID = "TWILL_RUN_ID"; --- End diff -- Is this still in the env? Isn't that we have the runid in the runtime spec? > Add TwillRuntimeSpecification for twill application > --------------------------------------------------- > > Key: TWILL-195 > URL: https://issues.apache.org/jira/browse/TWILL-195 > Project: Apache Twill > Issue Type: Improvement > Components: core > Reporter: Yaojie Feng > > Now we have RuntimeSpecification for twill runnable. We should also have a > TwillRuntimeSpecification to pass runtime requirements for twill applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)