[
https://issues.apache.org/jira/browse/TWILL-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549899#comment-15549899
]
ASF GitHub Bot commented on TWILL-195:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/13#discussion_r82066987
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/container/TwillContainerMain.java
---
@@ -112,9 +115,7 @@ public static void main(final String[] args) throws
Exception {
@Override
protected String getLoggerLevel(Logger logger) {
- String appLogLevel = System.getenv(EnvKeys.TWILL_APP_LOG_LEVEL);
-
- return Strings.isNullOrEmpty(appLogLevel) ?
super.getLoggerLevel(logger) : appLogLevel;
+ return logLevel == null ? super.getLoggerLevel(logger) :
logLevel.toString();
--- End diff --
Should use `.name()` instead of `.toString()`
> Add TwillRuntimeSpecification for twill application
> ---------------------------------------------------
>
> Key: TWILL-195
> URL: https://issues.apache.org/jira/browse/TWILL-195
> Project: Apache Twill
> Issue Type: Improvement
> Components: core
> Reporter: Yaojie Feng
>
> Now we have RuntimeSpecification for twill runnable. We should also have a
> TwillRuntimeSpecification to pass runtime requirements for twill applications.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
