[
https://issues.apache.org/jira/browse/TWILL-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549930#comment-15549930
]
ASF GitHub Bot commented on TWILL-195:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/13#discussion_r82069407
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -169,7 +172,7 @@ public Reader getInput() throws IOException {
}
private int getReservedMemory() {
- String value = System.getenv(EnvKeys.TWILL_RESERVED_MEMORY_MB);
+ String value = Integer.toString(twillRuntimeSpec.getReservedMemory());
if (value == null) {
--- End diff --
This logic doesn't make sense. The `twillRuntimeSpec.getReservedMemory`
already return an `int`. It can never be `null`. This method is unnecessary.
Just call `twillRuntimeSpec.getReservedMemory` whenever needed.
> Add TwillRuntimeSpecification for twill application
> ---------------------------------------------------
>
> Key: TWILL-195
> URL: https://issues.apache.org/jira/browse/TWILL-195
> Project: Apache Twill
> Issue Type: Improvement
> Components: core
> Reporter: Yaojie Feng
>
> Now we have RuntimeSpecification for twill runnable. We should also have a
> TwillRuntimeSpecification to pass runtime requirements for twill applications.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
