[
https://issues.apache.org/jira/browse/TWILL-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549807#comment-15549807
]
ASF GitHub Bot commented on TWILL-195:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/13#discussion_r82059585
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/ServiceMain.java ---
@@ -145,9 +145,8 @@ protected static Location createAppLocation(final
Configuration conf) {
if (UserGroupInformation.isSecurityEnabled()) {
ugi = UserGroupInformation.getCurrentUser();
} else {
- String fsUser = System.getenv(EnvKeys.TWILL_FS_USER);
if (fsUser == null) {
- throw new IllegalStateException("Missing environment variable "
+ EnvKeys.TWILL_FS_USER);
+ throw new IllegalStateException("Missing environment variable "
+ Constants.TWILL_FS_USER);
--- End diff --
This error message is not right. The fs user now comes in the runtime spec,
not from env, right? In fact, can this happen?
> Add TwillRuntimeSpecification for twill application
> ---------------------------------------------------
>
> Key: TWILL-195
> URL: https://issues.apache.org/jira/browse/TWILL-195
> Project: Apache Twill
> Issue Type: Improvement
> Components: core
> Reporter: Yaojie Feng
>
> Now we have RuntimeSpecification for twill runnable. We should also have a
> TwillRuntimeSpecification to pass runtime requirements for twill applications.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
