[
https://issues.apache.org/jira/browse/TWILL-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549548#comment-15549548
]
ASF GitHub Bot commented on TWILL-195:
--------------------------------------
Github user yaojiefeng commented on a diff in the pull request:
https://github.com/apache/twill/pull/13#discussion_r82036739
--- Diff:
twill-common/src/main/java/org/apache/twill/internal/Constants.java ---
@@ -78,6 +78,15 @@ private Files() {
}
}
+ /**
+ * Constants for twill environment variable names.
+ */
+ public static final class Environments {
--- End diff --
They are initially used in EnvKeys to pass system env variables. But with
the use of TwillRuntimeSpecification, they are no longer used as keys. They are
used as constants in configuration or error messages so I move them to
Constants class
> Add TwillRuntimeSpecification for twill application
> ---------------------------------------------------
>
> Key: TWILL-195
> URL: https://issues.apache.org/jira/browse/TWILL-195
> Project: Apache Twill
> Issue Type: Improvement
> Components: core
> Reporter: Yaojie Feng
>
> Now we have RuntimeSpecification for twill runnable. We should also have a
> TwillRuntimeSpecification to pass runtime requirements for twill applications.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
