[ 
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15631643#comment-15631643
 ] 

ASF GitHub Bot commented on TWILL-138:
--------------------------------------

Github user anew commented on a diff in the pull request:

    https://github.com/apache/twill/pull/14#discussion_r86287193
  
    --- Diff: 
twill-yarn/src/main/java/org/apache/twill/internal/container/TwillContainerService.java
 ---
    @@ -123,6 +142,9 @@ protected void doStart() throws Exception {
     
         runnable = Instances.newInstance((Class<TwillRunnable>) runnableClass);
         runnable.initialize(context);
    +    if (!setLogLevels(Maps.transformValues(logLevels, 
Functions.toStringFunction()))) {
    +      LOG.error("LoggerFactory is not a logback LoggerContext, cannot 
change log level");
    --- End diff --
    
    seems that the error logging belongs into the setLogLevels() method. 


> Runtime change of Application runnable log level
> ------------------------------------------------
>
>                 Key: TWILL-138
>                 URL: https://issues.apache.org/jira/browse/TWILL-138
>             Project: Apache Twill
>          Issue Type: New Feature
>          Components: core
>            Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill 
> application, next enhancement is to able to send command to update the 
> aggregate log level for a particular runnable in a Twill application.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to