[
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15651608#comment-15651608
]
ASF GitHub Bot commented on TWILL-138:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r87236796
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java
---
@@ -89,4 +90,59 @@
* @return A {@link Future} that will be completed when the restart
operation has been done.
*/
Future<String> restartInstances(String runnable, int instanceId, int...
moreInstanceIds);
+
+ /**
+ * Set the root log level for Twill applications in all containers.
+ *
+ * @param logLevel The log level for the root logger to change.
+ * @return A {@link Future} that will be completed when the set log
level operation has been done. It will carry
+ * the log level as a result.
+ */
+ Future<LogEntry.Level> setRootLogLevel(LogEntry.Level logLevel);
+
+ /**
+ * Set the root log level for a particular runnable.
+ *
+ * @param runnableName The name of the runnable to set the log level.
+ * @param logLevel The log level for the root logger to change.
+ * @return A {@link Future} that will be completed when the set log
level operation has been done. It will carry
+ * the log level as a result.
+ */
+ Future<LogEntry.Level> setRootLogLevel(String runnableName,
LogEntry.Level logLevel);
+
+ /**
+ * Set the log levels for requested logger names for Twill applications
running in a container.
+ *
+ * @param logLevels The {@link Map} contains the requested logger names
and log levels that need to be set.
+ * @return A {@link Future} that will be completed when the set log
level operation has been done. It will carry the
+ * {@link Map} of log levels as the result.
+ */
+ Future<Map<String, LogEntry.Level>> setLogLevels(Map<String,
LogEntry.Level> logLevels);
+
+ /**
+ * Set the log levels for requested logger names for a {@link
TwillRunnable}.
+ *
+ * @param runnableName The name of the runnable to set the log level.
+ * @param logLevelsForRunnable The {@link Map} contains the requested
logger name and log level that
+ * need to be changed.
+ * @return A {@link Future} that will be completed when the set log
level operation has been done. It will carry the
+ * {@link Map} of log levels as the result.
+ */
+ Future<Map<String, LogEntry.Level>> setLogLevels(String runnableName,
+ Map<String,
LogEntry.Level> logLevelsForRunnable);
+
+ /**
+ * Reset the log levels of all runnables to the default log level,
{@code LogEntry.Level.INFO}.
+ *
+ * @return A {@link Future} that will be completed when the set log
level operation has been done.
+ */
+ Future<String> resetLogLevelsToDefault();
+
+ /**
+ * Reset the log levels of the given runnable to the default log level,
{@code LogEntry.Level.INFO}.
+ *
+ * @return A {@link Future} that will be completed when the set log
level operation has been done. It will carry the
+ * runnable name as the result.
+ */
+ Future<String> resetRunnableLogLevelsToDefault(String runnableName);
--- End diff --
Same here, call it `resetLogLevels(String runnableName)` to mirror the
`set` methods.
> Runtime change of Application runnable log level
> ------------------------------------------------
>
> Key: TWILL-138
> URL: https://issues.apache.org/jira/browse/TWILL-138
> Project: Apache Twill
> Issue Type: New Feature
> Components: core
> Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill
> application, next enhancement is to able to send command to update the
> aggregate log level for a particular runnable in a Twill application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
